Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31702 ) Change subject: [codecs filter] msc_vlr_test_call: test codecs resolution ...................................................................... Patch Set 1: (10 comments) File tests/msc_vlr/msc_vlr_test_call.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/8646de3b_93ee705f PS1, Line 167: static void lu_geran_noauth() Bad function definition - void lu_geran_noauth() should probably be void lu_geran_noauth(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/8c3166c1_952b1287 PS1, Line 1013: OSMO_STRBUF_PRINTF(sb, " %s", m? m->sdp.subtype_name : "NULL"); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/7956d0d0_e4f98640 PS1, Line 1025: for (pos = perm_speech; *pos != LIST_END; pos++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/66b6572a_7447f1d1 PS1, Line 1031: static const char *strlist_name(const char *const* strs) "foo *const* bar" should be "foo *const*bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/3cc4bf6b_3d76f557 PS1, Line 1121: }\ space required after that close brace '}' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/3a286f59_e20ed63f PS1, Line 1160: for (pos = ms_bcap; *pos != LIST_END; pos++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/5e1b8e98_b7dcf51c PS1, Line 1176: struct gsm_mncc_rtp *mncc_rtp = (void*)&mncc; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/070373af_41d06996 PS1, Line 1288: struct gsm_mncc_rtp *mncc_rtp = (void*)&mncc; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/c9b87b3b_54f47e4c PS1, Line 1428: static void test_codecs() Bad function definition - void test_codecs() should probably be void test_codecs(void) File tests/msc_vlr/msc_vlr_tests.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/7207f117_7cf7134a PS1, Line 767: struct gsm_mncc_rtp *rtp = (void*)msg->data; "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I879ec61f523ad4ffc69a0b02810591f7c0261ff9 Gerrit-Change-Number: 31702 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 07 Mar 2023 00:40:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment