10 comments:
File tests/msc_vlr/msc_vlr_test_call.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548):
Patch Set #1, Line 167: static void lu_geran_noauth()
Bad function definition - void lu_geran_noauth() should probably be void lu_geran_noauth(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548):
Patch Set #1, Line 1013: OSMO_STRBUF_PRINTF(sb, " %s", m? m->sdp.subtype_name : "NULL");
spaces required around that '?' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548):
Patch Set #1, Line 1025: for (pos = perm_speech; *pos != LIST_END; pos++) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548):
Patch Set #1, Line 1031: static const char *strlist_name(const char *const* strs)
"foo *const* bar" should be "foo *const*bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548):
space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548):
Patch Set #1, Line 1160: for (pos = ms_bcap; *pos != LIST_END; pos++) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548):
Patch Set #1, Line 1176: struct gsm_mncc_rtp *mncc_rtp = (void*)&mncc;
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548):
Patch Set #1, Line 1288: struct gsm_mncc_rtp *mncc_rtp = (void*)&mncc;
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548):
Patch Set #1, Line 1428: static void test_codecs()
Bad function definition - void test_codecs() should probably be void test_codecs(void)
File tests/msc_vlr/msc_vlr_tests.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548):
Patch Set #1, Line 767: struct gsm_mncc_rtp *rtp = (void*)msg->data;
"(foo*)" should be "(foo *)"
To view, visit change 31702. To unsubscribe, or for help writing mail filters, visit settings.