Attention is currently required from: pespin, fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32183 ) Change subject: codec: add SID classification functions per GSM 06.31 & 06.81 ...................................................................... Patch Set 1: (1 comment) File include/osmocom/codec/codec.h: https://gerrit.osmocom.org/c/libosmocore/+/32183/comment/a209c6ce_3078d1d9 PS1, Line 85: etsi_sid_class @pespin - then how come none of the protocol constant definitions in <osmocom/gsm/protocol/gsm_XX_XX.h> begin with osmo_ or OSMO_? Take, for example, <osmocom/gsm/protocol/gsm_04_08.h>: there is an enum named gsm48_chan_mode in there, with individual constants named GSM48_CMODE_* - no osmo_ or OSMO_ prefix. It's exactly the same with all other definitions in those protocol headers in that directory: all prefixes begin with gsmXXX_ or GSMXXX_ rather than osmo_ and OSMO_ - or more precisely, they use osmo_ prefixes for internal Osmocom-controlled structures, but use gsmXXX_ for external protocol definitions. Now I did make the mistake of prefixing with etsi_ and ETSI_ rather than gsm631_ and GSM631_, and I put those definitions into <osmocom/codec/codec.h> instead of creating a new <osmocom/gsm/protocol/gsm_06_31.h> header. I'll make another patch version doing the latter. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie91a52c6f04689082d8004311517d8ce0c544916 Gerrit-Change-Number: 32183 Gerrit-PatchSet: 1 Gerrit-Owner: falconia &lt;falcon(a)freecalypso.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 03 Apr 2023 18:01:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia &lt;falcon(a)freecalypso.org&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-MessageType: comment