Attention is currently required from: pespin, fixeria.

View Change

1 comment:

• File include/osmocom/codec/codec.h:

  • Patch Set #1, Line 85: etsi_sid_class

    @falconia that's not really the rationale behind name prefixes. […]

    @pespin - then how come none of the protocol constant definitions in <osmocom/gsm/protocol/gsm_XX_XX.h> begin with osmo_ or OSMO_? Take, for example, <osmocom/gsm/protocol/gsm_04_08.h>: there is an enum named gsm48_chan_mode in there, with individual constants named GSM48_CMODE_* - no osmo_ or OSMO_ prefix. It's exactly the same with all other definitions in those protocol headers in that directory: all prefixes begin with gsmXXX_ or GSMXXX_ rather than osmo_ and OSMO_ - or more precisely, they use osmo_ prefixes for internal Osmocom-controlled structures, but use gsmXXX_ for external protocol definitions.

    Now I did make the mistake of prefixing with etsi_ and ETSI_ rather than gsm631_ and GSM631_, and I put those definitions into <osmocom/codec/codec.h> instead of creating a new <osmocom/gsm/protocol/gsm_06_31.h> header. I'll make another patch version doing the latter.

To view, visit change 32183. To unsubscribe, or for help writing mail filters, visit settings.