Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33087 ) Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ...................................................................... Patch Set 4: (1 comment) File include/osmocom/crypt/auth.h: https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/86bc710a_a904bdfd PS4, Line 121: OSMO_DEPRECATED_OUTSIDE("Use osmo_auth_gen_vec2 instead"); yes, we are. On the one hand there is osmo-auc-gen, which is ported in a follow-up patch. Then there is the IPA based OAP (osmo auth protocol), which even has static_assert around sizes of fields in the old sub_auth_data structures. This code is not use by anyone in ages and I have no interest in porting it. Last, but not least, there are all the authentication related unit tests which use the old API. I actually consider that a good thing, as that way we can be reasonably sure that this changeset doesn't break old users. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df Gerrit-Change-Number: 33087 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 09:19:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment