Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email ) Change subject: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ ...................................................................... Patch Set 1: (5 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/08754ed4_e6e6f01b PS1, Line 7: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ what's this $(ASCI)$ here at the end? File src/host/layer23/include/osmocom/bb/common/sysinfo.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/729c00cb_92406627 PS1, Line 179: uint8_t si10_cells; /* number neighbor cells found in SI 10 */ having si10_cells vs si10_cell below is highly misleading and prone to error. Bette call this si10_cell_count or si10_cell_len? File src/host/layer23/src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/0fd03ccb_ebe4cf64 PS1, Line 1040: static int16_t arfcn_from_freq(struct gsm48_sysinfo *s, uint16_t index) according to the param looks mmore like arfcn_from_index ;) is the index value a frequency in Hz? File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/fce466b9_88961418 PS1, Line 2900: /* receive "SYSTEM INFORMATION 10" message (9.1.50) */ why turning the first char into a lowcase her? https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/cd5a39df_e69837c1 PS1, Line 2909: LOGP(DRR, LOGL_INFO, "No cell selected, SYSTEM INFORMATION 10 " all these can git in one line. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I81c7929f6d951d8eef7d08624f0b72830370c448 Gerrit-Change-Number: 34614 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 03 Oct 2023 10:49:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment