Attention is currently required from: jolly.

View Change

5 comments:

• Commit Message:

  • Patch Set #1, Line 7: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$

    what's this $(ASCI)$ here at the end?

• File src/host/layer23/include/osmocom/bb/common/sysinfo.h:

  • Patch Set #1, Line 179: uint8_t si10_cells; /* number neighbor cells found in SI 10 */

    having si10_cells vs si10_cell below is highly misleading and prone to error.
    Bette call this si10_cell_count or si10_cell_len?

• File src/host/layer23/src/common/sysinfo.c:

  • Patch Set #1, Line 1040: static int16_t arfcn_from_freq(struct gsm48_sysinfo *s, uint16_t index)

    according to the param looks mmore like arfcn_from_index ;)
    is the index value a frequency in Hz?

• File src/host/layer23/src/mobile/gsm48_rr.c:

  • Patch Set #1, Line 2900: /* receive "SYSTEM INFORMATION 10" message (9.1.50) */

    why turning the first char into a lowcase her?

  • Patch Set #1, Line 2909: LOGP(DRR, LOGL_INFO, "No cell selected, SYSTEM INFORMATION 10 "

    all these can git in one line.

To view, visit change 34614. To unsubscribe, or for help writing mail filters, visit settings.