Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 )
Change subject: rlcmac: Fix Starting Time rfn->fn calculation
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/rlcmac/rlcmac_dec.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/b104753e_bc666167
PS3, Line 434: rfn_to_fn
Done
File tests/rlcmac/rlcmac_types_test.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/b8d5eda2_b2f6331a
PS3, Line 54: printf
Why not printing to `stderr`? It's easier to
read/review stuff when it's in one file.
agreed
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I00741289333853a8db472950ee2ac38dc2c74fd3
Gerrit-Change-Number: 34044
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Aug 2023 10:50:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment