Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37535?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim.apdu: Get rid of HexAdapter ...................................................................... pySim.apdu: Get rid of HexAdapter In the past, we always wrapped a HexAdapter around bytes-like data in order to make sure it's printed as hex-digits. However, now that we are doing JSON output it's much easier to let the pySim.utils.JsonEncoder take care of this in a generic way. We should do a similar migrtaion all over pySim (pySim-shell, filesystem, etc.) - but for now only do it in the low-hanging fruit of pySim-trace aka pySim.apdu Change-Id: I0cde40b2db08b4db9c10c1ece9ca6fdd42aa9154 --- M pySim/apdu/__init__.py M pySim/apdu/ts_102_221.py M pySim/apdu/ts_31_102.py M tests/test_apdu.py 4 files changed, 51 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/37535/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0cde40b2db08b4db9c10c1ece9ca6fdd42aa9154 Gerrit-Change-Number: 37535 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset