Attention is currently required from: laforge.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email )
Change subject: LAPD: Add support for RTS based polling and T200 ......................................................................
Patch Set 6:
(3 comments)
File include/osmocom/isdn/lapd_core.h:
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/434a3ec9_3d1e59da PS5, Line 155: unsigned
you are modifying a public data structure, which is ABI breakage. […]
Done
File src/isdn/lapd_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/7e619430_778d63ce PS5, Line 220: /
handle how? This requires more ddocumentation. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/f67e0606_6343fc1c PS5, Line 399: dl->flags = flags;
I guess it would leads to undefined behaviour if somebody called lapd_dl_set_flags to enable RTS mod […]
done, also moved the timer state to an enum, so it is not mixed with the flags that define behavior of LAPD.
-
jolly