Attention is currently required from: laforge.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email )
Change subject: LAPD: Add support for RTS based polling and T200
......................................................................
Patch Set 6:
(3 comments)
File include/osmocom/isdn/lapd_core.h:
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/434a3ec9_3d1e59da
PS5, Line 155: unsigned
you are modifying a public data structure, which is
ABI breakage. […]
Done
File src/isdn/lapd_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/7e619430_778d63ce
PS5, Line 220: /
handle how? This requires more ddocumentation. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/f67e0606_6343fc1c
PS5, Line 399: dl->flags = flags;
I guess it would leads to undefined behaviour if
somebody called lapd_dl_set_flags to enable RTS mod […]
done, also moved the timer
state to an enum, so it is not mixed with the flags that define behavior of LAPD.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib961b5a44911b99b0487641533301749c0286995
Gerrit-Change-Number: 34985
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 15 Nov 2023 13:58:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment