Attention is currently required from: fixeria. wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29387 )

Change subject: added support for fill bits and basic link defragmentation (also thanks to SQ5BPF) ......................................................................

Patch Set 2:

(7 comments)

Patchset:

PS2: Thanks for your attention, I resolved the issues.

File src/tetra_llc_pdu.h:

https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/55e91c83_fd285847 PS1, Line 80:

unrelated ws changed

tl_sdu_len needs to be changed from a uint8_t to uint32_t because, due to defragmentation, pdus may become longer than 255 bits. As such, I feel like it is related to this change, however, I now mention the change in the commit message.

File src/tetra_mac_pdu.h:

https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/bd224154_54691990 PS1, Line 160:

unrelated ws change

Hmm missed this one in my second patch set. I was trying to keep the linter from complaining. In the future, I'll push a commit fixing linting issues in files I touch before committing my actual modifications, is that ok?

File src/tetra_mac_pdu.c:

https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/2910a82b_bcfbb131 PS1, Line 64:

In this particular place, it's a good change. But it should be done in a separate patch.

Removed these changes from the patch

https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/c0ffeaa7_7c6328fa PS1, Line 97: cad->type = bits_to_uint(cur, 2); cur += 2;

Please keep the original formatting in this patch. […]

Removed these changes from the patch

https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/e10a0629_3c39e6e0 PS1, Line 387:

why are you changing this? […]

Removed these changes from the patch

File src/tetra_upper_mac.c:

https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/7aa4150d_d951feef PS1, Line 51: msgb_reset

I don't think calling msgb_reset() is needed right after calling msgb_alloc(). […]

You're right, removed the msgb_reset() call.