Attention is currently required from: fixeria.
7 comments:
Patchset:
Thanks for your attention, I resolved the issues.
File src/tetra_llc_pdu.h:
unrelated ws changed
tl_sdu_len needs to be changed from a uint8_t to uint32_t because, due to defragmentation, pdus may become longer than 255 bits. As such, I feel like it is related to this change, however, I now mention the change in the commit message.
File src/tetra_mac_pdu.h:
unrelated ws change
Hmm missed this one in my second patch set. I was trying to keep the linter from complaining. In the future, I'll push a commit fixing linting issues in files I touch before committing my actual modifications, is that ok?
File src/tetra_mac_pdu.c:
In this particular place, it's a good change. But it should be done in a separate patch.
Removed these changes from the patch
Patch Set #1, Line 97: cad->type = bits_to_uint(cur, 2); cur += 2;
Please keep the original formatting in this patch. […]
Removed these changes from the patch
why are you changing this? […]
Removed these changes from the patch
File src/tetra_upper_mac.c:
Patch Set #1, Line 51: msgb_reset
I don't think calling msgb_reset() is needed right after calling msgb_alloc(). […]
You're right, removed the msgb_reset() call.
To view, visit change 29387. To unsubscribe, or for help writing mail filters, visit settings.