Attention is currently required from: neels, fixeria, msuraev, dexter.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31454 )

Change subject: trau_pcu_ericsson: add testvectors for MCS1-MCS8 ......................................................................

Patch Set 3:

(1 comment)

File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/31454/comment/888763a1_5a4faae8 PS2, Line 2087: printf(" ccu_data_ind.tav=%02x\n", frame.u.ccu_data_ind.tav);

Since I receive a lot of criticism regarding the code duplication I will clean this up in a follow u […]

It's not about "optimization", but about code maintainability and readability. So if N times the same thing happens, it's easier to read and maintain if it's one fucntion, rather than somebody having to look at N copies and trying to identify if they really do all the same thing or differ in some subtle way.