Attention is currently required from: fixeria, pespin.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32733 )

Change subject: paging: parse PCUIF data indication outside of paging.c ......................................................................

Patch Set 6:

(2 comments)

File src/common/paging.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/5e89f3d6_7d6e0f53 PS5, Line 273: uint8_t macblock_len

In GSM all MAC blocks must have `length == GSM_MACBLOCK_LEN`. […]

That is correct. In the new protocol the field is GSM_MACBLOCK_LEN, so we can be sure that the length always fits. I have moved the check now to pcu_sock.c.

File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/c028ab60_25db7ad3 PS5, Line 679: memcpy(imsi, data_req->data, 3);

`osmo_strlcpy(&imsi[0], data_req->data, sizeof(imsi))` - this looks more readable and requires no pr […]

(This code section will be removed when we change to PCUIF v.11)