Attention is currently required from: fixeria, pespin.

View Change

2 comments:

• File src/common/paging.c:

  • Patch Set #5, Line 273: uint8_t macblock_len

    In GSM all MAC blocks must have `length == GSM_MACBLOCK_LEN`. […]

    That is correct. In the new protocol the field is GSM_MACBLOCK_LEN, so we can be sure that the length always fits. I have moved the check now to pcu_sock.c.

• File src/common/pcu_sock.c:

  • Patch Set #5, Line 679: memcpy(imsi, data_req->data, 3);

    `osmo_strlcpy(&imsi[0], data_req->data, sizeof(imsi))` - this looks more readable and requires no pr […]

    (This code section will be removed when we change to PCUIF v.11)

To view, visit change 32733. To unsubscribe, or for help writing mail filters, visit settings.