Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32406 ) Change subject: ts_51_011: fix EF_ServiceTable: use self for static method ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I'm not an OOP expert either, but I see nothing conceptually wrong with a derived class overloading a static method in python. The only rason it's static is that we don't need 'self' in it, as it purely operates on data outside of the instance. And a derived class may well override that. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3590dda341d534deb1b7f4743ea31ab16dbd6912 Gerrit-Change-Number: 32406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 May 2023 00:14:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment