Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-bsc/+/38087?usp=email )
Change subject: Introduce hashtable to lookup bts by LAC
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/neighbor_ident.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/38087/comment/e0dd77a6_e2d31952?usp… :
PS2, Line 381: f (bts_tmp->location_area_code != lac)
: continue;
shouldn't this be now an error message in all of
those iterations (not just this function)? After a […]
Not really. AFAIU different
LACs can end up in the same hashtable bucket/llist due to hashing function, it's
totally fine and expected...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/38087?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id523027b49e0f58cd2c8c9b4dee619de415dbd15
Gerrit-Change-Number: 38087
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 10 Sep 2024 23:05:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>