Attention is currently required from: arehbein.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33206 )
Change subject: stream (cosmetic): Fix osmo_panic log fmts ......................................................................
Patch Set 8: Code-Review+1
(3 comments)
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/82787bb9_6a043b1f PS6, Line 615: cli->state);
there's also the __func__ or __FUNCTION__ macro that could be used here. […]
Done
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/1a6dd28c_88af7da5 PS8, Line 613: osmo_panic("osmo_stream_cli_write_cb() called with unexpected state %d\n", cli->state); why the line wrap here ? having this in one line certainly doesn't exceed the permitted line length.
https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/3ed57ea9_670768c8 PS8, Line 633: } why the line wrap here ? having this in one line certainly doesn't exceed the permitted line length.