Attention is currently required from: fixeria.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email )

Change subject: asp: Introduce support to configure and enable TCP keep-alive ......................................................................

Patch Set 2:

(2 comments)

File src/ss7_asp.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/6b071c95_fb2cbd... : PS2, Line 800: rc =

You're assigning a value to `rc`, but then after the `switch` it gets overwritten.

I did that on purpose, I don't want failure to set this make all fail, specially regarding SCTP INIT params applied on kernels which may have bad support for it, etc. There's already error logging happening in the lower layers btw. I'll add some explicit lines stating so.

File src/ss7_asp_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/d8c0eb22_f9144a... : PS2, Line 512: "num-ostreams"

Acknowledged

Done