Attention is currently required from: neels, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30978 )
Change subject: layer23: Move layer2-socket VTY command to common/ ......................................................................
Patch Set 1:
(5 comments)
File src/host/layer23/include/osmocom/bb/common/vty.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/3fbd3849_7d0b1e6b PS1, Line 25: extern bool l23_vty_reading;
adding l23_vty_reading seems unrelated to the move. […]
It's not unrelated, it is needed by one of the functions being moved.
File src/host/layer23/src/common/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/3de633b6_18046820 PS1, Line 166: layer2_socket_path = optarg;
are you sure about changing the allocation here? […]
It's not unrelated. Since it becomes non-static and it's initially set to some value not allocated from the talloc here, I prefer keeping it outside of talloc here in order to end up in a situation where depending on how it was set, talloc is used or not. It's just part of the cleanup.
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/ab1b914f_5afa6517 PS1, Line 292: rc = layer2_open(ms, ms->settings.layer2_socket_path);
this seems like a bugfix unrelated to the move. ms->settings. […]
This is part of the commit. It is precisely what allows configuring the socket path from VTY for layer23 apps supporting VTY (such as modem).
File src/host/layer23/src/common/vty.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/5745c81b_0ecda512 PS1, Line 168: /tmp/osmocom_l2
"Unix socket, default '" L2_DEFAULT_SOCKET_PATH "'"
Ack
https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/ae1ebc55_28bee622 PS1, Line 243: /* placeholder for shared VTY commands */
the empty function was a placeholder, now it is used and no longer a placeholder
It's still a placeholder for shared VTY commands.
-
pespin