Attention is currently required from: laforge, pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32184 )
Change subject: codec: add SID preening functions for FR & EFR ......................................................................
Patch Set 4:
(1 comment)
File src/codec/gsm610.c:
https://gerrit.osmocom.org/c/libosmocore/+/32184/comment/02277292_9e454ab0 PS4, Line 432: return false;
I think the compiler knows this can never be reached and hence there's no need for explicit return h […]
Looking closer, I see that you are right - the macro definition of OSMO_ASSERT() and the declaration of osmo_panic() combined together do give the compiler enough info that no return is possible from that OSMO_ASSERT(0) call. I am submitting another patch version with those superfluous lines removed.
-
falconia