Attention is currently required from: osmith. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 to look at the new patch set (#2). Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... bsc: Fix regression in TC_assignment_emerg_setup_deny_bts A recent commit introduced a regression which made TC_assignment_emerg_setup_deny_bts fail. The problematic commit (see hash below) set "pars.ra := f_rnd_ra_emerg()" in the helper function, which made the BSC early reject the CHAN RQD with ImmAssRej in the case the BTS policy forbids emergency calls. In that scenario, rejection can be done early because there's no need to wait to find out which MSC it is aimed at. This scenario, however, is already being validated by test TC_chan_rqd_emerg_deny. The scenario TC_assignment_emerg_setup_deny_bts was testing is actually one where CHAN RQD doesn't contain reason="emergency call", which means BTS doesn't early reject it, but only knows about it being an emergency call when a CC Emergency Setup is sent to it, time at which it releases the call. Hence, this commit sets back pars.ra = f_rnd_ra_emerg() only on the ..._deny_msc testcase, since it's the only test really needing it. Fixes: 14076d3b721030c5f0610403cbc7e75a6eed5351 Related: OS#5849 Change-Id: I8d342e5938f6293ae45ee399796417651768af5d --- M bsc/BSC_Tests.ttcn 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/30997/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset