[L] Change in ...osmo-s1gw[master]: enft_kpi: retrieve per-eNB traffic counters - gerrit-log

28 May 2025

Attention is currently required from: laforge, pespin.

fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email )

Change subject: enft_kpi: retrieve per-eNB traffic counters
......................................................................

Patch Set 8:

(2 comments)

File config/sys.config:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/73038fb4_c584…
:
PS8, Line 24: %% {enft_kpi_enable, true}, %% whether to enable the NFT KPI module
(default: false)
...
  IMHO the fact that you are using enftables is totally
irrelevant ... 
If I were Neels, I would have said this is bikeshedding:

...
  Bikeshedding refers to the phenomenon of spending
excessive time and energy on trivial details (like the color of a bike shed) while
neglecting more important or critical issues ... 
Maybe this is not the best naming choice, but this is certainly not the most important
detail at the moment. We could go further and omit the `nft` completely together with the
`e`, because the user should not care if the counters are obtained via NFT or any other
means. Should it be `gtpu_kpi_` then?

...
  The PFCP stuff is also coming from a
"pfcplib", and yet they are not named "pfcplib_*". 
The stuff coming from `enftables` library does not have the prefix either.
It's just the module name and env parameters reflecting the module they're related
to.

File rebar.config:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/c13e0f34_47f5…
:
PS8, Line 13:          {git,
"https://gitea.osmocom.org/vyanitskiy/enftables.git", {branch,
"fixeria/json"}}},
...
  IMHO if this is a repo which is not meant to end up in
another namespace 
Not sure what you mean here. Again, I'll move the library to
https://gitea.osmocom.org/erlang/ and push an updated patch revision soon (before merging
it). What's wrong here?

-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd
Gerrit-Change-Number: 40281
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Wed, 28 May 2025 12:41:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;