Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File config/sys.config:

  • Patch Set #8, Line 24: %% {enft_kpi_enable, true}, %% whether to enable the NFT KPI module (default: false)

    IMHO the fact that you are using enftables is totally irrelevant ...

    If I were Neels, I would have said this is bikeshedding:

    Bikeshedding refers to the phenomenon of spending excessive time and energy on trivial details (like the color of a bike shed) while neglecting more important or critical issues ...

    Maybe this is not the best naming choice, but this is certainly not the most important detail at the moment. We could go further and omit the `nft` completely together with the `e`, because the user should not care if the counters are obtained via NFT or any other means. Should it be `gtpu_kpi_` then?

    The PFCP stuff is also coming from a "pfcplib", and yet they are not named "pfcplib_*".

    The stuff coming from `enftables` library does not have the prefix either.
    It's just the module name and env parameters reflecting the module they're related to.

• File rebar.config:

  • Patch Set #8, Line 13: {git, "https://gitea.osmocom.org/vyanitskiy/enftables.git", {branch, "fixeria/json"}}},

    IMHO if this is a repo which is not meant to end up in another namespace

    Not sure what you mean here. Again, I'll move the library to https://gitea.osmocom.org/erlang/ and push an updated patch revision soon (before merging it). What's wrong here?

To view, visit change 40281. To unsubscribe, or for help writing mail filters, visit settings.