Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435?usp=email ) Change subject: errata 2.6.10 ...................................................................... Patch Set 1: (17 comments) File gcc/gcc/startup_same54.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/c5813e67_567c6bd… : PS1, Line 671: __attribute__((naked,noreturn)) void Reset_Handler(void) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/93dff4cd_4177237… : PS1, Line 675: __asm volatile ( please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/9373fc81_8e64a37… : PS1, Line 676: "movs r0, #0\n" code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/2b7d17c3_0779c8e… : PS1, Line 676: "movs r0, #0\n" please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/6816a398_4f7c417… : PS1, Line 677: "ldr r1, =0x40002000\n" code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/8a9b5a11_e37c0aa… : PS1, Line 677: "ldr r1, =0x40002000\n" please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/40b45f7c_3d22779… : PS1, Line 678: "strb r0, [r1]\n" code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/0574c5d5_fc5a4fb… : PS1, Line 678: "strb r0, [r1]\n" please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/f55a6fab_770c558… : PS1, Line 679: "bl _Reset_Handler\n" code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/2365f18b_5a863eb… : PS1, Line 679: "bl _Reset_Handler\n" please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/d710b350_a601a77… : PS1, Line 680: ::: "r0", "r1", "memory" code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/248d2c37_893c0f1… : PS1, Line 680: ::: "r0", "r1", "memory" please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/5fa96671_e7967db… : PS1, Line 681: ); please, no spaces at the start of a line File usb_flash_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/af46e7a9_7fd8228… : PS1, Line 136: bool startup_wdt_inactive = _user_area_read_bits((void*)NVMCTRL_USER, 62, 1) != 1; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/eeb8c7f1_f3a8924… : PS1, Line 137: if (chiprev_lower_revG && startup_wdt_inactive) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/b6f308b1_a172260… : PS1, Line 139: _user_area_write_bits((void*)NVMCTRL_USER, 50, 0, 4); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/3d45facf_e307e61… : PS1, Line 140: _user_area_write_bits((void*)NVMCTRL_USER, 62, 1, 1); "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ifbc6a3dfe91462029fce50ed42f20440debaa552 Gerrit-Change-Number: 39435 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 29 Jan 2025 18:24:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No