View Change

17 comments:

• File gcc/gcc/startup_same54.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 671: __attribute__((naked,noreturn)) void Reset_Handler(void)

    space required after that ',' (ctx:VxV)

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 675: __asm volatile (

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 676: "movs r0, #0\n"

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 676: "movs r0, #0\n"

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 677: "ldr r1, =0x40002000\n"

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 677: "ldr r1, =0x40002000\n"

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 678: "strb r0, [r1]\n"

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 678: "strb r0, [r1]\n"

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 679: "bl _Reset_Handler\n"

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 679: "bl _Reset_Handler\n"

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 680: ::: "r0", "r1", "memory"

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 680: ::: "r0", "r1", "memory"

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 681: );

    please, no spaces at the start of a line

• File usb_flash_main.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 136: bool startup_wdt_inactive = _user_area_read_bits((void*)NVMCTRL_USER, 62, 1) != 1;

    "(foo*)" should be "(foo *)"

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 137: if (chiprev_lower_revG && startup_wdt_inactive)

    that open brace { should be on the previous line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 139: _user_area_write_bits((void*)NVMCTRL_USER, 50, 0, 4);

    "(foo*)" should be "(foo *)"

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21260):

    Patch Set #1, Line 140: _user_area_write_bits((void*)NVMCTRL_USER, 62, 1, 1);

    "(foo*)" should be "(foo *)"

To view, visit change 39435. To unsubscribe, or for help writing mail filters, visit settings.