Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 2: (219 comments) File src/gsm/tuak/KeccakP-1600-3gpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/240e1648_80d6ae70 PS2, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]); space prohibited between function name and open parenthesis '(' File src/gsm/tuak/KeccakP-1600-3gpp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/88f84fef_6fea8600 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/82c84ca3_bd0b3afc PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2fc80263_ebcf6dc8 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aba3f727_b7a6aa46 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f817d79b_b37b3976 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05604d55_7dc35eaa PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/81c7e9d5_7b538030 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b0393e6_c1e3897b PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/72326f39_90400c47 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e09344a_30d0e3ea PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a6bda17_8c146ec5 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/432695b0_4e6c1144 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7b6405cb_10580edc PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b1704f4_adbe0df9 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/61e9fe60_6a26f3fe PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/70d3284c_0310c744 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0cb6843d_95bd5de3 PS2, Line 13: 15,21,8,18,2,61,56,14}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/56e0ccb6_a48cbc8f PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d9434946_cee1e73b PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f7b7332d_87e50212 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9dfa1695_7e7d4d96 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b9c4c0b3_ac183f4d PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/75bc208a_2252c219 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a0a58572_f83f0b85 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d5342bf_cb7edae5 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8e2d3cb3_c7584ef1 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f626e4d6_73f5ce8b PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aec51ffb_4251917e PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6b4420d9_47151bfe PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9dec71f7_13444901 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8349a792_38616d85 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d6ae162d_9ab0b9f1 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05acfde2_2ea9c090 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c897d60b_4b469026 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bd3e75d8_4da0e934 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b01175ce_2f5cdf4a PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/be97d1cb_0e367963 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/29236ec7_ce8d9898 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fc0c0b45_9f5ad072 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/679955aa_12a5ee48 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1d8baa2c_73af7bb2 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/48896748_28c9a452 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2632acac_c1ea7dd2 PS2, Line 16: 23,2,8,14,15,21}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d634dff2_9e80f113 PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dc5de524_3926a8ad PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2e4e4e1b_9d96c4c3 PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c8f3c6e3_31f4b268 PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6591089_dda267da PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1f6ef3c6_8212c12e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/07429942_0ea1cb9c PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/244356a6_5daca31d PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d0992ea_f4c7243c PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8b027066_0ca57eb8 PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f1307598_36db0dfd PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/826b37eb_e8d90d48 PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/59d40adf_b71db00e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d32ecceb_25d9803a PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3cc786f8_49850b8b PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a347d567_f132c05e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/85400000_9b839de1 PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/99aa6ed9_20f0555e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/efacbe8f_06ca4e75 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cddf556e_cb94809b PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/30d4e04b_0e05bc96 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d0490c03_4179ecf3 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e06eab41_459bfe78 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a827a937_667c0f46 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/efb6b032_bd3d0b74 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/221704d6_e4cc3cef PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1c72a60d_a7a22708 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6d0f600_32118092 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bd6800f9_bfe7343d PS2, Line 32: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/caba35a1_cbb7958f PS2, Line 32: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/17eaafe3_2e5a6f27 PS2, Line 32: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89d10163_5330d3cd PS2, Line 32: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3597b357_96754025 PS2, Line 34: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4de6b36_d1c71848 PS2, Line 34: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aac082f8_baf9dd07 PS2, Line 34: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/943ef6f6_3d3488fb PS2, Line 36: for(i=0; i<5; ++i, s+=5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b7992d12_b35b5211 PS2, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6e813f33_2be9bc0e PS2, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7b63f0ab_3d0b98ef PS2, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8ad13732_0df446df PS2, Line 36: for(i=0; i<5; ++i, s+=5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/047ec174_82207601 PS2, Line 46: for(i=1; i<25; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c833b79_e55dd121 PS2, Line 46: for(i=1; i<25; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e4d7699_53f3b02f PS2, Line 46: for(i=1; i<25; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e182331b_99e0dfcf PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a8714010_13d016ae PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c7afd48b_9bcc68b7 PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/01f91f89_8c3ec5b0 PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/84786177_0f201b7d PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7e2921a3_079b15bc PS2, Line 54: for(i=0; i<5; ++i, s += 5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/88d0ab86_08fa84a5 PS2, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0240b367_f4724725 PS2, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4df932f9_4bc489f4 PS2, Line 54: for(i=0; i<5; ++i, s += 5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e780e10_7178e33d PS2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/085c54d9_dc2e5fe9 PS2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/702c783b_22651b3a PS2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92820bdf_d044d057 PS2, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/091ac23b_42ad225d PS2, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3a81f12e_c23996f3 PS2, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5470eb05_53d71ac3 PS2, Line 79: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/da422303_6930924f PS2, Line 79: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/526e0a00_8f07601e PS2, Line 79: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5f7ddc05_83aab3c9 PS2, Line 79: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3304e8d2_24425ed7 PS2, Line 81: for(i=0; i<40; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a651cb9e_38bffca0 PS2, Line 81: for(i=0; i<40; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/36caf501_622bcb37 PS2, Line 81: for(i=0; i<40; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a8db551c_daaf0015 PS2, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ff6683e6_fce25677 PS2, Line 83: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7961f5eb_45794224 PS2, Line 83: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2d09fd3f_522b7d53 PS2, Line 83: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/09c72d54_cd8303d8 PS2, Line 83: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fda2215c_f836875b PS2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b45ab20d_60cb12f4 PS2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b97d047f_6ee75feb PS2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fbf47e70_8cd98d41 PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/daf0dea3_9c834db4 PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4abe4ada_6c12696e PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/df93ea00_d60b6029 PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aa50bafc_091d7410 PS2, Line 87: for(j = t[i+7]>>7, k=7; k; --k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5b3a09ca_26d659d9 PS2, Line 87: for(j = t[i+7]>>7, k=7; k; --k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ab8d1e07_01d02232 PS2, Line 89: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/957a79d6_8d4364fa PS2, Line 89: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/db8739ac_f82e16eb PS2, Line 89: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fde7574e_3a4ec8d2 PS2, Line 89: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/574b6fa6_c25ef6eb PS2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/424c4f4a_43c7a112 PS2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1548ee5a_41f48ad4 PS2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/697c2f10_705bf7e6 PS2, Line 94: for(i=8; i<200; i+=8) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa9d47ce_3cf070d8 PS2, Line 94: for(i=8; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a2570590_24c06705 PS2, Line 94: for(i=8; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/750eb819_adfa55a4 PS2, Line 94: for(i=8; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/35960919_b3e25af4 PS2, Line 94: for(i=8; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78630f90_9c284532 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bf1e3027_c7306723 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9e178b87_2eca2e18 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c5bf1d6b_d5437783 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/da1dc8fa_6a2d2450 PS2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/87d272a7_37e6a07a PS2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cdf1589a_dd45289c PS2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c41d7469_b0b0f57a PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fc6f338e_dcf7c303 PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f5098a61_3252776d PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cd870857_4983065e PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e8ff8840_c6e26d15 PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3daa75cd_9646875d PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a61ec466_9c8eb85b PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c2004305_5a86750d PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ea41fa3e_aa5d85ee PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3bc0fe82_8bcc6811 PS2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e38a8ae6_b2ac2811 PS2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f0fa8ab_eee23cff PS2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/de78d5b0_069004f7 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fdc7c8e7_55cee436 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b4e598b5_871f6936 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5c18ab85_dd7978c7 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0e0bc769_9ed9c8c0 PS2, Line 111: for(i=0; i<200; i+=40) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/06d566e4_89534802 PS2, Line 111: for(i=0; i<200; i+=40) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5ca87c29_d96f3a1c PS2, Line 111: for(i=0; i<200; i+=40) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ba2daa3_039a309c PS2, Line 111: for(i=0; i<200; i+=40) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a06123a8_3127bf6e PS2, Line 111: for(i=0; i<200; i+=40) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/09df563e_101f193a PS2, Line 112: { for(j=0; j<40; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b501487d_47f6ea63 PS2, Line 112: { for(j=0; j<40; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a67502c6_fd3d13b0 PS2, Line 112: { for(j=0; j<40; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/af4bc274_8fa99ffb PS2, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3b47518a_3d132d8d PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/52118f3f_c268a861 PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/208b1348_fdd9b57c PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '^=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b16f79c9_b3012c59 PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b72f34e7_342c8ce8 PS2, Line 135: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3af63cad_852d5bb1 PS2, Line 135: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0c886833_3f22b9c0 PS2, Line 135: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/84f26758_cb6f166c PS2, Line 135: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5fe3ff5e_29319aa0 PS2, Line 137: for(i=0; i<10; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/23ed2218_32f0d3e6 PS2, Line 137: for(i=0; i<10; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a4b28f9_f125e311 PS2, Line 137: for(i=0; i<10; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/488744ac_7484184d PS2, Line 139: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b380ede9_2e9d46ed PS2, Line 139: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fcd26dd0_ad4832b0 PS2, Line 139: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3f10db5b_2ae562ab PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f45e8094_03c0617d PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/74ac93b9_bfea5aa9 PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0be470b0_d81f686d PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '%=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1830c304_4c204ece PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/186787a5_8fde6515 PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ba4a7986_b13a66e4 PS2, Line 143: if(j==8) break; spaces required around that '==' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1336faa7_d537c54c PS2, Line 143: if(j==8) break; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e9cc6352_2f2feee2 PS2, Line 148: for(i=2; i<50; i+=2) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a86f4d0b_5ec2e333 PS2, Line 148: for(i=2; i<50; i+=2) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b45c3d63_95aacf93 PS2, Line 148: for(i=2; i<50; i+=2) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b8314fe1_cde269a9 PS2, Line 148: for(i=2; i<50; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ee460312_b5da22c2 PS2, Line 148: for(i=2; i<50; i+=2) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa9c4c4e_4c344051 PS2, Line 153: s[i] = t[1-k], s[i+1] = t[k]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0a2f4171_9104aa0f PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9df74ea4_ca9e7eab PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b93f2ff_fbcc5b67 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ca0a3dbd_68af1569 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/211b015d_d31895f0 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e4a1f5c5_9a75c4f6 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/42ff7897_fd75c7f1 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/830f4ad7_8109547f PS2, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b8c223a_1c438e56 PS2, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ba4620b_28d7878a PS2, Line 158: s[i]=s[j], s[i+1]=s[j+1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ac343b50_98e78896 PS2, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/75805e31_6bba407c PS2, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/50218401_587b5f19 PS2, Line 159: s[i]=t[0], s[i+1]=t[1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5cb226f7_075ca495 PS2, Line 162: for(i=0; i<5; ++i, s+=10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ff3004e7_ed4ad036 PS2, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bd0a0803_857e4fab PS2, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/634e65ef_508639cc PS2, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/16a1190c_7c3ee6c9 PS2, Line 162: for(i=0; i<5; ++i, s+=10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fe8eb0c3_3e78e3f9 PS2, Line 163: { for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6a60f333_68afe68c PS2, Line 163: { for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/033829a8_28d52880 PS2, Line 163: { for(j=0; j<10; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a27e6507_f5aa40b0 PS2, Line 165: for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/24c01036_9097dd69 PS2, Line 165: for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5e8eac81_d27430c5 PS2, Line 165: for(j=0; j<10; ++j) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 2 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Comment-Date: Tue, 30 May 2023 14:39:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment