Attention is currently required from: laforge.
219 comments:
File src/gsm/tuak/KeccakP-1600-3gpp.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]);
space prohibited between function name and open parenthesis '('
File src/gsm/tuak/KeccakP-1600-3gpp.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 13: 15,21,8,18,2,61,56,14};
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 13: 15,21,8,18,2,61,56,14};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 13: 15,21,8,18,2,61,56,14};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 13: 15,21,8,18,2,61,56,14};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 13: 15,21,8,18,2,61,56,14};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 13: 15,21,8,18,2,61,56,14};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 13: 15,21,8,18,2,61,56,14};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 13: 15,21,8,18,2,61,56,14};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 16: 23,2,8,14,15,21};
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 16: 23,2,8,14,15,21};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 16: 23,2,8,14,15,21};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 16: 23,2,8,14,15,21};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 16: 23,2,8,14,15,21};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 16: 23,2,8,14,15,21};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 19: 217,83,82,192,26,106,241,208,33,120};
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 19: 217,83,82,192,26,106,241,208,33,120};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 19: 217,83,82,192,26,106,241,208,33,120};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 19: 217,83,82,192,26,106,241,208,33,120};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 19: 217,83,82,192,26,106,241,208,33,120};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 19: 217,83,82,192,26,106,241,208,33,120};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 19: 217,83,82,192,26,106,241,208,33,120};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 19: 217,83,82,192,26,106,241,208,33,120};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 19: 217,83,82,192,26,106,241,208,33,120};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 19: 217,83,82,192,26,106,241,208,33,120};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 32: for(round=0; round<24; ++round)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 32: for(round=0; round<24; ++round)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 32: for(round=0; round<24; ++round)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 32: for(round=0; round<24; ++round)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 34: for(i=0; i<5; ++i)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 34: for(i=0; i<5; ++i)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 34: for(i=0; i<5; ++i)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 36: for(i=0; i<5; ++i, s+=5)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 36: for(i=0; i<5; ++i, s+=5)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 36: for(i=0; i<5; ++i, s+=5)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 36: for(i=0; i<5; ++i, s+=5)
spaces required around that '+=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 36: for(i=0; i<5; ++i, s+=5)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 46: for(i=1; i<25; ++i)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 46: for(i=1; i<25; ++i)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 46: for(i=1; i<25; ++i)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j);
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j);
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j);
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j);
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j);
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 54: for(i=0; i<5; ++i, s += 5)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 54: for(i=0; i<5; ++i, s += 5)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 54: for(i=0; i<5; ++i, s += 5)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 54: for(i=0; i<5; ++i, s += 5)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j];
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j];
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j];
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57))
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 79: for(round=0; round<24; ++round)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 79: for(round=0; round<24; ++round)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 79: for(round=0; round<24; ++round)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 79: for(round=0; round<24; ++round)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 81: for(i=0; i<40; ++i)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 81: for(i=0; i<40; ++i)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 81: for(i=0; i<40; ++i)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i];
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 83: for(i=0; i<200; i+=8)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 83: for(i=0; i<200; i+=8)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 83: for(i=0; i<200; i+=8)
spaces required around that '+=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 83: for(i=0; i<200; i+=8)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8)
spaces required around that '+=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 87: for(j = t[i+7]>>7, k=7; k; --k)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 87: for(j = t[i+7]>>7, k=7; k; --k)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 89: for(i=0; i<200; i+=8)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 89: for(i=0; i<200; i+=8)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 89: for(i=0; i<200; i+=8)
spaces required around that '+=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 89: for(i=0; i<200; i+=8)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 94: for(i=8; i<200; i+=8)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 94: for(i=8; i<200; i+=8)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 94: for(i=8; i<200; i+=8)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 94: for(i=8; i<200; i+=8)
spaces required around that '+=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 94: for(i=8; i<200; i+=8)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 104: for(i=1; (j=Pi[i])>1; i=j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 104: for(i=1; (j=Pi[i])>1; i=j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 104: for(i=1; (j=Pi[i])>1; i=j)
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 104: for(i=1; (j=Pi[i])>1; i=j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 104: for(i=1; (j=Pi[i])>1; i=j)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 111: for(i=0; i<200; i+=40)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 111: for(i=0; i<200; i+=40)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 111: for(i=0; i<200; i+=40)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 111: for(i=0; i<200; i+=40)
spaces required around that '+=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 111: for(i=0; i<200; i+=40)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 112: { for(j=0; j<40; ++j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 112: { for(j=0; j<40; ++j)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 112: { for(j=0; j<40; ++j)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40];
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j];
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j];
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j];
spaces required around that '^=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j];
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 135: for(round=0; round<24; ++round)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 135: for(round=0; round<24; ++round)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 135: for(round=0; round<24; ++round)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 135: for(round=0; round<24; ++round)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 137: for(i=0; i<10; ++i)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 137: for(i=0; i<10; ++i)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 137: for(i=0; i<10; ++i)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 139: for(i=0; i<5; ++i)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 139: for(i=0; i<5; ++i)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 139: for(i=0; i<5; ++i)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10)
spaces required around that '%=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 143: if(j==8) break;
spaces required around that '==' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 143: if(j==8) break;
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 148: for(i=2; i<50; i+=2)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 148: for(i=2; i<50; i+=2)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 148: for(i=2; i<50; i+=2)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 148: for(i=2; i<50; i+=2)
spaces required around that '+=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 148: for(i=2; i<50; i+=2)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 153: s[i] = t[1-k], s[i+1] = t[k];
Possible comma where semicolon could be used
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j)
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 158: s[i]=s[j], s[i+1]=s[j+1];
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 158: s[i]=s[j], s[i+1]=s[j+1];
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 158: s[i]=s[j], s[i+1]=s[j+1];
Possible comma where semicolon could be used
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 159: s[i]=t[0], s[i+1]=t[1];
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 159: s[i]=t[0], s[i+1]=t[1];
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 159: s[i]=t[0], s[i+1]=t[1];
Possible comma where semicolon could be used
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 162: for(i=0; i<5; ++i, s+=10)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 162: for(i=0; i<5; ++i, s+=10)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 162: for(i=0; i<5; ++i, s+=10)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 162: for(i=0; i<5; ++i, s+=10)
spaces required around that '+=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 162: for(i=0; i<5; ++i, s+=10)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 163: { for(j=0; j<10; ++j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 163: { for(j=0; j<10; ++j)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 163: { for(j=0; j<10; ++j)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 165: for(j=0; j<10; ++j)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 165: for(j=0; j<10; ++j)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625):
Patch Set #2, Line 165: for(j=0; j<10; ++j)
space required before the open parenthesis '('
To view, visit change 33094. To unsubscribe, or for help writing mail filters, visit settings.