Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38657?usp=email ) Change subject: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer conflicts ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: as this touches the low-level interface to readers, I think it would be good to manually test with some of the non-PCSC readers. Not sure if you did that. If you did, please add related comments to the commit log message. File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/38657/comment/00c573d0_4899aaf9?usp=em… : PS1, Line 243: cl I find the use of multiple inheritance here a bit confusing. Can we not simply have * an APDU-level LinkBase, and then * a derived TpduLinkBase (or better called T0TpduLinkBase?) class that inherits from LinkBase The actual transports (pc/sc, modem, etc.) would then either inherit from LinkBase or from TpduLinkBase? https://gerrit.osmocom.org/c/pysim/+/38657/comment/f1d6907c_6e8f6978?usp=em… : PS1, Line 320: __send_apdu_T1 I'm not actually sure there is anything T=1 specific here. It is just sending an APDU. The same would IMHO apply in case of a contactless card using T=15 (ISO14443). So naming wise, I'm not sure if we should talk about T=1 / T1 in situations where we're not absolutely sure that protocol is involved (e.g. by explicitly instructing PC/SC to use it). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8b56d7804a2b4c392f43f8540e0b6e70001a8970 Gerrit-Change-Number: 38657 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 04:31:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No