Attention is currently required from: dexter.

3 comments:

Patchset:
- Patch Set #1:
  as this touches the low-level interface to readers, I think it would be good to manually test with some of the non-PCSC readers. Not sure if you did that. If you did, please add related comments to the commit log message.
File pySim/transport/__init__.py:
- Patch Set #1, Line 243: cl
  I find the use of multiple inheritance here a bit confusing. Can we not simply have
  - an APDU-level LinkBase, and then
  - a derived TpduLinkBase (or better called T0TpduLinkBase?) class that inherits from LinkBase
  The actual transports (pc/sc, modem, etc.) would then either inherit from LinkBase or from TpduLinkBase?
- Patch Set #1, Line 320: __send_apdu_T1
  I'm not actually sure there is anything T=1 specific here. It is just sending an APDU. The same would IMHO apply in case of a contactless card using T=15 (ISO14443). So naming wise, I'm not sure if we should talk about T=1 / T1 in situations where we're not absolutely sure that protocol is involved (e.g. by explicitly instructing PC/SC to use it).

To view, visit change 38657. To unsubscribe, or for help writing mail filters, visit settings.