[S] Change in ...pyosmocom[master]: utils: add unrpad() - gerrit-log

5 Mar 2025


      Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email )
Change subject: utils: add unrpad()
......................................................................
Patch Set 1: -Code-Review
(1 comment)
File src/osmocom/utils.py:
https://gerrit.osmocom.org/c/python/pyosmocom/+/39600/comment/4aebfd59_b20e5... :
PS1, Line 125:     """unpad string on the right side -- reverse of rpad().
...
hmm indeed .. […]
wouldn't it be good then to add unrpad as a method to the hexstr type?  Maybe also call it rstrip there to make it look like the stdlib, as that's what it basically is?
-- 
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I48c23390926f8c9412624edb4481e7f4cd3f4b46
Gerrit-Change-Number: 39600
Gerrit-PatchSet: 1
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Wed, 05 Mar 2025 14:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Comment-In-Reply-To: laforge laforge@osmocom.org