Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: pcu_l1_if: signal BTS model via PCUIF ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: This patch breaks compatibility with osmo-bts v1.7.1 (current latest tag). ``` DL1IF ERROR pcu_l1_if.cpp:1349 Received 1006 bytes on PCU Socket, but primitive pcu_prim->u.info_ind size is 1007, discarding ``` We shall not merge it as-is. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: osmith/1.4.0 Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047 Gerrit-Change-Number: 35318 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 11:15:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment