fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35652?usp=email )
Change subject: GSUP: Fix missing and wrongly sorted IEs in ts_GSUP_IE_PdpInfo
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I don't think so. Proof of it is that TTCN3,
erlang and libosmocore all used different orders. […]
Not sure about Erlang
projects, but the current TTCN-3 implementation definitely requires specific ordering of
TLVs; otherwise the templates won't match. We could change definition of `GSUP_IEs` as
follows:
```
-type record of GSUP_IE GSUP_IEs;
+type set of GSUP_IE GSUP_IEs;
```
This would simplify things a bit.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35652?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I65e586187d7230f122644c101f8467becae6e204
Gerrit-Change-Number: 35652
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Jan 2024 14:01:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment