Attention is currently required from: pespin, msuraev.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30960 )
Change subject: Move osmocom_ms to a separate file
......................................................................
Patch Set 5:
(1 comment)
File src/host/layer23/src/common/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/bcbdfa27_3e26682e
PS5, Line 272: llist_add_tail(&ms->entity, &ms_list);
i guess this llist_add would also belong in
osmocom_ms_alloc()?
i see now you are moving it in a later patch. maybe join the two
patches?
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30960
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Icb4891cc1e4a0ecb5f09cb8a84b0ebe1b91a46b8
Gerrit-Change-Number: 30960
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 15 Jan 2023 23:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment