Attention is currently required from: laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32931 ) Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008 ...................................................................... Patch Set 4: (12 comments) File include/osmocom/gsm/gsm0808_utils.h: https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/5a876d7b_41798ed2 PS1, Line 26: stru Done https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/a83cd926_d44145ae PS1, Line 33: #include <sys/socket.h> After correcting my patches, this change is not required anymore, so I removed it. https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/fc854186_5b5568bf PS1, Line 67: /* Preemtion Capability indicator */ Done https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/73634d30_6decd6d5 PS1, Line 139: struct gsm0808_cell_id_list2 cil; Done https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/71472737_d57e81dd PS1, Line 151: GSM0808_TALKER_NORMAL_PRIORITY = 0x00, Done File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/21eed3fb_c731c676 PS1, Line 2231: osmo_store32be(gc->callref << 5, ptr); Done https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/12daf8a3_a6016e44 PS1, Line 2255: gc->sf = (elem[3] >> 4) & 0x1; Done https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/3c269a64_38a9b14e PS1, Line 2281: ptr[0] = pri->pci << 6; Done https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/7b236a19_c2b3da98 PS1, Line 2303: pri->pci = (elem[0] >> 6) & 0x1; Done https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/3712f9a9_30d84adb PS1, Line 2329: ptr[0] = ff->tcp << 4; Done https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/6c71749d_e6b1b736 PS1, Line 2352: ff->tcp = (elem[0] >> 4) & 0x1; Done https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/b9152719_dd5035e7 PS1, Line 2517: *ci = osmo_load32le(elem); Yes, this is LE. I added a comment line that states it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd Gerrit-Change-Number: 32931 Gerrit-PatchSet: 4 Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 24 May 2023 12:48:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: comment