[S] Change in libosmocore[master]: Add support for receiving Bter UI frames at lapdm.c - gerrit-log

24 May 2023


      Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32934 )
Change subject: Add support for receiving Bter UI frames at lapdm.c
......................................................................
Patch Set 4:
(2 comments)
File src/gsm/lapdm.c:
https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/40d4ff22_6e17d6fa 
PS1, Line 841: 		/* FIXME */
...
pespin: please don't resolve with ACK!
Done
https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/8af125c2_d9e3f161 
PS1, Line 735: 			/* If UI on SACCH sent by BTS, lapdm_fmt must be B4 */
...
please don't breake the else if like this, the if-else sequence in here is already complex enough to […]
Done
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32934
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If04115884743455c7bf2b2bc5f7e49e74b6ffb60
Gerrit-Change-Number: 32934
Gerrit-PatchSet: 4
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 24 May 2023 12:49:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment