Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29159 )
Change subject: cosmetic: constify function parameters, return proper error ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29159/comment/8dc9229f_2543b9c4 PS1, Line 7: cosmetic: constify function parameters, return proper error the summary should indicate the scope ("sccp_scoc.c:...")
Patchset:
PS1: please separate "constify" and "change rc" in distinct commits
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29159/comment/a872b49f_f0fa1b93 PS1, Line 704: return -ENOMSG; -ENOMEM would be the proper code here.
but actually, none of the callers even look at the return code. what is this change about?