Attention is currently required from: msuraev.

Patch set 1:Code-Review -1

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 7: cosmetic: constify function parameters, return proper error

    the summary should indicate the scope ("sccp_scoc.c:...")

• Patchset:

  • Patch Set #1:

    please separate "constify" and "change rc" in distinct commits

• File src/sccp_scoc.c:

  • Patch Set #1, Line 704: return -ENOMSG;

    -ENOMEM would be the proper code here.

    but actually, none of the callers even look at the return code. what is this change about?

To view, visit change 29159. To unsubscribe, or for help writing mail filters, visit settings.