Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 ) Change subject: layer23: Introduce APN VTY node ...................................................................... Patch Set 1: (5 comments) File src/host/layer23/include/osmocom/bb/common/settings.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2780): https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/6c661e1c_95808644 PS1, Line 190: struct osmobb_apn *ms_find_apn_by_name(struct osmocom_ms *ms, const char* apn_name); "foo* bar" should be "foo *bar" File src/host/layer23/src/common/apn.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2780): https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/f8dad5bb_71d8e03e PS1, Line 60: } adding a line without newline at end of file File src/host/layer23/src/common/settings.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2780): https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/27b8d893_4fef4cd9 PS1, Line 236: while((apn = llist_first_entry_or_null(&set->apn_list, struct osmobb_apn, list))) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2780): https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/16b281e8_3064b7fd PS1, Line 243: struct osmobb_apn *ms_find_apn_by_name(struct osmocom_ms *ms, const char* apn_name) "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2780): https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/cd242921_52306718 PS1, Line 253: } adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e Gerrit-Change-Number: 30992 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 16 Jan 2023 17:23:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment