Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30994 ) Change subject: layer23: Introduce tun.{c,h} ...................................................................... Patch Set 4: (19 comments) File src/host/layer23/include/osmocom/bb/common/tun.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/573a4857_bcafdfdb PS4, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/5225cfd9_a47a1ddd PS4, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/8f1647c4_d425c49b PS4, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/e8348cf4_22643c27 PS4, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack, Unnecessary space before function pointer arguments File src/host/layer23/src/common/tun.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/eab543b1_78f877c5 PS4, Line 48: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/07427985_f59ab32e PS4, Line 53: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/9d9bd55f_7b67766c PS4, Line 65: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/0036de06_8388573b PS4, Line 104: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/dd607443_87916a4d PS4, Line 123: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/c79d4e60_5cb27927 PS4, Line 186: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/9ff3c9f1_c40a7665 PS4, Line 214: strcpy(ifr.ifr_name, dev_name); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/640a53ab_1565d70d PS4, Line 221: strncpy((*tun)->devname, ifr.ifr_name, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/425cbba1_0d881df5 PS4, Line 229: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/4f04445e_f959c25d PS4, Line 230: strncpy((*tun)->devname, dev_name, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/fc41a734_01996b9d PS4, Line 243: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/526394a5_0618c4ea PS4, Line 273: strncpy(areq.ifra_name, (*tun)->devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/ccc1421e_c25e5bc6 PS4, Line 283: while (ioctl(fd, SIOCDIFADDR, (void *)&areq) != -1) ; space prohibited before semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/d3216d81_38ed6a84 PS4, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/3cd0d235_3e7360b6 PS4, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len)) Unnecessary space before function pointer arguments -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd Gerrit-Change-Number: 30994 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 15:28:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment