laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28023 )

Change subject: abis_nm: run gsm_bts_check_cfg during oml bring up ......................................................................

abis_nm: run gsm_bts_check_cfg during oml bring up

Don't wait until RSL link goes up to check the reported features against the config. Do it in the OML bring up right after the features are reported.

Related: SYS#5922, OS#5538 Change-Id: I6b1b4ef3e163528ed186050d848ec089a4315a7c --- M src/osmo-bsc/abis_nm.c 1 file changed, 6 insertions(+), 0 deletions(-)

Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified

diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index cdb1fa6..a460f3e 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -719,6 +719,12 @@ else rc = parse_attr_resp_info_attr(bts, trx, foh, &tp);

+ if (gsm_bts_check_cfg(bts) != 0) { + LOGP(DLINP, LOGL_ERROR, "(bts=%u) BTS config invalid, dropping BTS!\n", bts->nr); + ipaccess_drop_oml_deferred(bts); + return -EINVAL; + } + osmo_signal_dispatch(SS_NM, S_NM_GET_ATTR_REP, mb);

return rc;