Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39765?usp=email ) Change subject: stp: STP_Tests_IPA.TC_tmt_loadshare_sls: Fix test expectancies ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File stp/STP_Tests_IPA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39765/comment/e08b0c9e_6d98… : PS1, Line 309: where were https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39765/comment/6fbce1b6_bbca… : PS1, Line 313: if (not ((num_rx_1 == iter_per_asp and num_rx_2 == 0) or (num_rx_2 == iter_per_asp and num_rx_1 == 0))) { Could be rewritten as the following, not sure if more readable: ```suggestion if (num_rx1 != iter_per_asp or num_rx2 != 0) and (num_rx2 != iter_per_asp or num_rx1 != 0) { ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39765?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68856e11a92b707eb11ab4813390e6faf3c54b69 Gerrit-Change-Number: 39765 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 13:40:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes