[M] Change in pysim[master]: pySim-shell: Detect different eUICC types and print during start-up - gerrit-log

16 Sep 2024

Attention is currently required from: dexter, fixeria.

laforge has posted comments on this change by laforge. (
https://gerrit.osmocom.org/c/pysim/+/38049?usp=email )

Change subject: pySim-shell: Detect different eUICC types and print during start-up
......................................................................

Patch Set 6:

(3 comments)

File pySim/euicc.py:

https://gerrit.osmocom.org/c/pysim/+/38049/comment/95d453dc_2b1263cb?usp=em… :
PS6, Line 580:  -> bool:
...
  This function does not return a `bool`, but always
`None` (implicit return) AFAICS. Done

https://gerrit.osmocom.org/c/pysim/+/38049/comment/96a691bb_81bb2bec?usp=em… :
PS6, Line 586: @staticmethod
...
  (just some ideas below, not blocking) […] Done

https://gerrit.osmocom.org/c/pysim/+/38049/comment/a5f28ee5_176bbe11?usp=em… :
PS6, Line 616:  -> bool:
...
  likewise, change to `-> None`? Done

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/38049?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I54ea4ce663693f3951040dcc8a16bf532bf99c02
Gerrit-Change-Number: 38049
Gerrit-PatchSet: 6
Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 16 Sep 2024 11:26:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;