Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email ) Change subject: sgsn: Introduce test TC_attach_pdp_act_user ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/8eec5fe9_3797… PS2, Line 614: Iu only put `_iu_` in the name if this is Iu only? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/1c461747_eaf8… PS2, Line 635: f_service_request Likewise, name it `f_iu_...`? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/e505d928_a306… PS2, Line 651: [is_gb(ran_index)] This is never true since you ensure the Iu mode above. Are you maybe planning to add Gb support to this API later? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/4677e0fc_096d… PS2, Line 806: completing the PDP ACT "... waiting for RANAP RAB AssReq" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5f0cb51457395d95bde22732b032786211cb7b61 Gerrit-Change-Number: 37593 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jul 2024 21:39:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment