Attention is currently required from: arehbein, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32354 )
Change subject: gsm_objclass2obj(): Change signature/set NACK cause ......................................................................
Patch Set 2:
(1 comment)
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/5816d636_fde453c6 PS2, Line 1106: gsm_objclass2obj This call may overwrite the cause previously set by `gsm_objclass2mo()`. We may want two checks here instead of a combined one, i.e.
``` if ((mo = gsm_objclass2mo(bts, foh->obj_class, &foh->obj_inst, &c)) == NULL) return oml_fom_ack_nack(msg, c); if ((obj = gsm_objclass2obj(bts, foh->obj_class, &foh->obj_inst, &c)) == NULL) return oml_fom_ack_nack(msg, c); ```
-
fixeria