Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31967 ) Change subject: contrib: Add BER testing tool ...................................................................... Patch Set 4: (27 comments) File contrib/ber/rtp_ber.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/c65649b2_3cf62e14 PS4, Line 97: static const char *amr_rate_by_ft[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/f8203e4d_340ae594 PS4, Line 237: for (i=0; i<8*payload_len; i++) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/0ad08d0e_cdead8bb PS4, Line 237: for (i=0; i<8*payload_len; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/0df2feb3_00d6c676 PS4, Line 237: for (i=0; i<8*payload_len; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/ebc642ba_6005cfb0 PS4, Line 246: if (ones < 32) // This frames is probably us underrunning Tx, don't use it that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/e43c322a_345511e9 PS4, Line 258: if (as->state == RUNNING) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/91c2a237_d9642ad9 PS4, Line 361: else else should follow close brace '}' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/9e715f3e_5b669d63 PS4, Line 399: if (as->state == WAIT_CONN) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/fba959be_2962ac7f PS4, Line 420: if (rtp_seq_num_diff(seq_number, as->rx_last_seq) > 1) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/9bc89e79_287f3780 PS4, Line 431: if (d > 1) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/6c0c5344_76f0037b PS4, Line 485: while (1) { braces {} are not necessary for single statement blocks File contrib/ber/rtp_gen_map.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/aa989f59_b5dd0e13 PS4, Line 30: int i,j; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/3ec680e4_037ff216 PS4, Line 34: for (i=0; i<260; i++) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/8129d2f7_e7897774 PS4, Line 34: for (i=0; i<260; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/399a9e8a_6bc5b281 PS4, Line 34: for (i=0; i<260; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/21c22134_73aab101 PS4, Line 55: for (i=0; i<260; i++) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/8564ed3b_14aac40f PS4, Line 55: for (i=0; i<260; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/277eecd6_8b2c265b PS4, Line 55: for (i=0; i<260; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/a61d4327_b7b571fe PS4, Line 96: for (i=0; i<16; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/cc738cd7_af9484b0 PS4, Line 96: for (i=0; i<16; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/bfcdfe03_8459908c PS4, Line 99: for (i=0; i<244; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/19c13e06_1905671d PS4, Line 99: for (i=0; i<244; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/6e0fd3bb_921dca10 PS4, Line 102: for (i=0; i<4; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/a942c3d3_a10f7a8f PS4, Line 102: for (i=0; i<4; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/f5f980fa_d8c16c11 PS4, Line 116: for (i=0; i<len; i++) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/530f3e17_1bdc6a19 PS4, Line 116: for (i=0; i<len; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/2302c469_95b6b413 PS4, Line 116: for (i=0; i<len; i++) spaces required around that '<' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cffa0ae959e29ec61775b13185fd1057ed7485a Gerrit-Change-Number: 31967 Gerrit-PatchSet: 4 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: tnt &lt;tnt(a)246tNt.com&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Comment-Date: Mon, 20 Mar 2023 13:15:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment