Attention is currently required from: laforge.
27 comments:
File contrib/ber/rtp_ber.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 97: static const char *amr_rate_by_ft[] = {
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 237: for (i=0; i<8*payload_len; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 237: for (i=0; i<8*payload_len; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 237: for (i=0; i<8*payload_len; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 246: if (ones < 32) // This frames is probably us underrunning Tx, don't use it
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 258: if (as->state == RUNNING)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 399: if (as->state == WAIT_CONN)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 420: if (rtp_seq_num_diff(seq_number, as->rx_last_seq) > 1) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 431: if (d > 1)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 485: while (1) {
braces {} are not necessary for single statement blocks
File contrib/ber/rtp_gen_map.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 30: int i,j;
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 34: for (i=0; i<260; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 34: for (i=0; i<260; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 34: for (i=0; i<260; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 55: for (i=0; i<260; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 55: for (i=0; i<260; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 55: for (i=0; i<260; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 96: for (i=0; i<16; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 96: for (i=0; i<16; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 99: for (i=0; i<244; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 99: for (i=0; i<244; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 102: for (i=0; i<4; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 102: for (i=0; i<4; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 116: for (i=0; i<len; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 116: for (i=0; i<len; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5273):
Patch Set #4, Line 116: for (i=0; i<len; i++)
spaces required around that '<' (ctx:VxV)
To view, visit change 31967. To unsubscribe, or for help writing mail filters, visit settings.