Attention is currently required from: msuraev. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31048 ) Change subject: SI: add RR short PD message types ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/31048/comment/02ad1082_4b133949 PS1, Line 1553: #define GSM48_MT_RR_SH_SI10bis 0xA Do we have a certain rule as to why the suffixes here and in the next line are in lower-case? Just wondering because everything else is capitalized -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifbd0aabe826298fa4715eb4eb2ff8363e765933d Gerrit-Change-Number: 31048 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Jan 2023 21:40:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment