Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email ) Change subject: gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h ...................................................................... Patch Set 1: (3 comments) File gtp/gtp_internal.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40435/comment/07e0669a_f60f54e0?us… : PS1, Line 10: #define GTP_LOGPKG(pri, peer, pack, len, fmt, args...) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40435/comment/aef68bd9_439e558d?us… : PS1, Line 17: #define LOGP_WITH_ADDR(ss, level, peer, fmt, args...) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40435/comment/e68eeb72_c66b4670?us… : PS1, Line 19: inet_ntoa((peer)->sin_addr), ntohs((peer)->sin_port), \ please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I3b59b067fc75d2ca2cbfe5cec010615e9b788923 Gerrit-Change-Number: 40435 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 04 Jun 2025 16:29:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No