Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email )
Change subject: gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h ......................................................................
Patch Set 1:
(3 comments)
File gtp/gtp_internal.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40435/comment/07e0669a_f60f54e0?usp... : PS1, Line 10: #define GTP_LOGPKG(pri, peer, pack, len, fmt, args...) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40435/comment/aef68bd9_439e558d?usp... : PS1, Line 17: #define LOGP_WITH_ADDR(ss, level, peer, fmt, args...) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40435/comment/e68eeb72_c66b4670?usp... : PS1, Line 19: inet_ntoa((peer)->sin_addr), ntohs((peer)->sin_port), \ please, no spaces at the start of a line