Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133 ) Change subject: cnpool: extract Mobile Identity from RANAP payload ...................................................................... Patch Set 1: (6 comments) File include/osmocom/hnbgw/context_map.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7706): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133/comment/51c571de_06fed8d8 PS1, Line 13: ( (HNB_CTX_MAP)->cnlink ? (HNB_CTX_MAP)->cnlink->name \ space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7706): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133/comment/0187e235_f6d2cf7c PS1, Line 14: : ((HNB_CTX_MAP)->is_ps ? "PS" : "CS") ) \ space prohibited before that close parenthesis ')' File src/osmo-hnbgw/hnbgw_l3.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7706): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133/comment/10c39cf3_40e08b45 PS1, Line 105: ra_id = (void*)cur; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7706): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133/comment/bb32e155_21948b69 PS1, Line 133: ra_id = (void*)cur; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7706): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133/comment/a1221e5c_5b231359 PS1, Line 174: gh = (void*)nas_pdu; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7706): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133/comment/aa0aaf4e_0fc64bdb PS1, Line 192: lu = (struct gsm48_loc_upd_req*)gh->data; "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I373d665c9684b607207f68094188eab63209db51 Gerrit-Change-Number: 33133 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 01 Jun 2023 02:43:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment